-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench colors for Welcome/Playground #25798
Comments
@bpasero we had a chat about this today in the meeting. For themes that go all out currently they stick out pretty bad: I suggested maybe making this look more like a |
I suggest to use the same approach as for the Quick links on the Welcome page by default when there is no explicit workbench color defined (I'll do that with #18905). Using |
@chrmarti I mean making it look like a peekViewResult pane as in getting the borders as well, maybe that a horrible idea though 😄 |
I like how the current slight variation of color makes buttons (and in the future embedded editors) look a little deepened without pulling up fences. I'd go without borders. |
Removed all hardcoded colors. |
Quick links on the Welcome page already derive their background color from the editor's background. We should do the same for the Playground's embedded editors (#18905).
Additionally we should have workbench colors for the two. Tracking this here.
The text was updated successfully, but these errors were encountered: