Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench colors for Welcome/Playground #25798

Closed
chrmarti opened this issue May 2, 2017 · 5 comments
Closed

Workbench colors for Welcome/Playground #25798

chrmarti opened this issue May 2, 2017 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming themes Color theme issues
Milestone

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented May 2, 2017

Quick links on the Welcome page already derive their background color from the editor's background. We should do the same for the Playground's embedded editors (#18905).

Additionally we should have workbench colors for the two. Tracking this here.

@chrmarti chrmarti added feature-request Request for new features or functionality workbench labels May 2, 2017
@Tyriar
Copy link
Member

Tyriar commented May 2, 2017

@bpasero we had a chat about this today in the meeting. For themes that go all out currently they stick out pretty bad:

image

I suggested maybe making this look more like a peekViewResults pane and using those colors as they're already definable and target the same area. Alternatively using a separate key and defaulting to a transparent white/black background.

@chrmarti
Copy link
Collaborator Author

chrmarti commented May 2, 2017

I suggest to use the same approach as for the Quick links on the Welcome page by default when there is no explicit workbench color defined (I'll do that with #18905).

Using peekViewResults has the drawback that it can have the same background color as the editor background because the peek view comes with borders whereas the embedded editors on the Playground come without.

@Tyriar
Copy link
Member

Tyriar commented May 2, 2017

@chrmarti I mean making it look like a peekViewResult pane as in getting the borders as well, maybe that a horrible idea though 😄

@chrmarti
Copy link
Collaborator Author

chrmarti commented May 2, 2017

I like how the current slight variation of color makes buttons (and in the future embedded editors) look a little deepened without pulling up fences. I'd go without borders.

@bpasero bpasero added this to the May 2017 milestone May 3, 2017
@bpasero bpasero assigned chrmarti and unassigned bpasero May 6, 2017
@chrmarti chrmarti added the plan-item VS Code - planned item for upcoming label May 8, 2017
@kieferrm kieferrm mentioned this issue May 8, 2017
44 tasks
@bpasero bpasero added the themes Color theme issues label May 22, 2017
@chrmarti chrmarti reopened this May 25, 2017
chrmarti added a commit that referenced this issue May 25, 2017
chrmarti added a commit that referenced this issue May 25, 2017
chrmarti added a commit that referenced this issue May 25, 2017
@chrmarti
Copy link
Collaborator Author

Removed all hardcoded colors.

dbaeumer pushed a commit that referenced this issue May 26, 2017
dbaeumer pushed a commit that referenced this issue May 26, 2017
dbaeumer pushed a commit that referenced this issue May 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants