Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore how to run a DebugAdapter inside the extension (instead of separate process) #40906

Closed
weinand opened this issue Dec 28, 2017 · 2 comments
Closed

Explore how to run a DebugAdapter inside the extension (instead of separate process) #40906

weinand opened this issue Dec 28, 2017 · 2 comments
Assignees
@weinand
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Milestone
January 2018

Comments

@weinand
Copy link
Contributor

weinand commented Dec 28, 2017 •
edited
Loading

For simple debug adapters that are implemented in JS/TS and are closely tied to the extension it is an overkill and development hassle to run them as a separate process.

Explore a way to run a debug adapter inside the extension by means of the "vscode-debugadapter" npm module.
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Dec 28, 2017
@weinand weinand self-assigned this Dec 28, 2017
@weinand weinand mentioned this issue Dec 28, 2017
Closed
@weinand
Copy link
Contributor Author

weinand commented Dec 28, 2017

A first cut of this is available in the embedded-DA branch of mock-debug.

This commit shows the approach.

@weinand weinand added this to the December 2017/January 2018 milestone Dec 28, 2017
@weinand weinand changed the title Explore hot to run DebugAdapter inside extension (instead of separate process) Explore how to run DebugAdapter inside extension (instead of separate process) Dec 28, 2017
@kieferrm kieferrm mentioned this issue Jan 3, 2018
Closed
55 tasks
@weinand weinand changed the title Explore how to run DebugAdapter inside extension (instead of separate process) Explore how to run a DebugAdapter inside the extension (instead of separate process) Jan 3, 2018
@weinand
Copy link
Contributor Author

weinand commented Jan 8, 2018

I've removed the diagnostic message "shutdown ignored in server mode" from the npm module "vscode-debugadapter" because "server mode" is now an official way to run a debug adapter.

weinand added a commit to microsoft/vscode-debugadapter-node that referenced this issue Jan 8, 2018
@weinand
remove diagnostic message "shutdown ignored in server mode"; see micr…
bdb3509 
…osoft/vscode#40906
@weinand weinand closed this as completed Jan 8, 2018
@weinand weinand mentioned this issue Jan 29, 2018
Closed
2 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
1 participant
@weinand