Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically update trusted domains based on repository remote and GH id #97532

Closed
JacksonKearl opened this issue May 11, 2020 · 1 comment
Closed

Dynamically update trusted domains based on repository remote and GH id #97532

JacksonKearl opened this issue May 11, 2020 · 1 comment
Assignees
@JacksonKearl
Labels
feature-request Request for new features or functionality on-testplan
Milestone
May 2020

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented May 11, 2020 •
edited
Loading

The trusted domain logic should trust:

https://github.com/CURRENT_REPO_OWNER/CURRENT_REPO_NAME/**

and

https://github.com/CURRENT_USER/**

by default.
@JacksonKearl JacksonKearl self-assigned this May 11, 2020
@JacksonKearl JacksonKearl added this to the May 2020 milestone May 11, 2020
@kieferrm kieferrm mentioned this issue May 11, 2020
Closed
61 tasks
@JacksonKearl
Copy link
Contributor Author

1636e54 for CURRENT_USER.

@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label May 12, 2020
JacksonKearl pushed a commit that referenced this issue May 12, 2020
Restrict trusted domain auto-insertion to github domains.
6ba01ef 
Ref #97532.
Reasoning is otherwise it would be possible for an extension to simply insert an entry into .git/config. This is still possible in thoery, but at least only for github.
@JacksonKearl JacksonKearl mentioned this issue May 12, 2020
Closed
2 tasks
@JacksonKearl JacksonKearl mentioned this issue May 26, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@JacksonKearl and others