Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebornix/nb list focus #118482

Merged
merged 27 commits into from
Mar 12, 2021
Merged

Rebornix/nb list focus #118482

merged 27 commits into from
Mar 12, 2021

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Mar 8, 2021

This PR is an experiment of using customized notebook navigation command to archive #117868. Those commands should be replaced by #118045 thus they are not going to be merged into main (that's why folding is not taken into consideration as List View will handle the view position for me correctly). However we can use this set of commands to help demonstrate the experience we may want to see in Notebook

Screen.Recording.2021-03-08.at.11.37.53.AM.mov

@rebornix rebornix marked this pull request as ready for review March 12, 2021 19:08
@rebornix rebornix merged commit 1a5d7f4 into main Mar 12, 2021
@rebornix rebornix deleted the rebornix/nb-list-focus branch March 12, 2021 19:56
@joaomoreno
Copy link
Member

@rebornix Hopefully life got easier for you here. 👌

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants