Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow notebook extensions run in dedicated extension host #144787

Closed
wants to merge 5 commits into from

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Mar 9, 2022

This is an attempt to run notebook extensions in a dedicated extension host without being affected by other extensions (or vice versa). In the changes, I spawned another LocalExtensionHost for notebook extensions. As @alexdima pointed out, it adds notebook knowledge to the extension service. A better approach is that extension service allow others to register filters (then the notebook component can register a filter for notebook extensions) and extension meet the filter can be grouped into a new extension host.

@rebornix rebornix added this to the March 2022 milestone Mar 10, 2022
@alexdima
Copy link
Member

@rebornix I've just merged #144840 . You can now use:

"extensions.experimental.affinity": {
   "ms-toolsai.jupyter": 1
}

This will move the extension together with all dependencies or dependents to a separate extension host.

@alexdima
Copy link
Member

@rebornix I suggest to close this out in favor of #144840 . Please give it a try and let me know if it works for the Notebooks use-case.

@rebornix
Copy link
Member Author

Thanks @alexdima , will give it a try today!

@rebornix rebornix closed this Mar 14, 2022
@rebornix rebornix removed this from the March 2022 milestone Mar 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants