Add languages indicator to Settings editor settings #150233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to show how the label looks? |
rzhao271
force-pushed
the
rzhao271/se-lang-indicator
branch
from
d359e92 to
9a9fe82
Compare
|
Here is an image of how the language indicator currently looks, next to the scope overrides indicator.
|
rzhao271
force-pushed
the
rzhao271/se-lang-indicator
branch
from
9a9fe82 to
ee15e00
Compare
|
It looks like GitHub doesn't re-sign commits for you when you select "Update with rebase" to update the PR branch. |
|
Please let me know if it is good for review? |
|
Closing. I'll put up a newer PR soon that builds on top of PR #152401. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #145731, by adding a new label for language overrides. This label currently shows when a setting has an extension-contributed language-specific default setting value override, but it should also show when a setting has a language-specific value in general.
This PR is not yet ready to merge. I have created some smaller debt-reduction PRs to merge first that are independent of this feature.