Support version for proposed APIs #216608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems, there is something broken with my changes. I will take a look and fix. |
|
Fixed! |
jrieken
requested changes
Jun 19, 2024
src/vs/workbench/services/extensions/common/extensionsProposedApi.ts
Outdated
Show resolved
Hide resolved
jrieken
approved these changes
Jun 19, 2024
bricefriha
pushed a commit
to bricefriha/vscode
that referenced
this pull request
Jun 26, 2024
Support version for proposed APIs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #214294
Updated
generateApiProposalNamesto generate proposals with versions. Moved theextensionsApiProposalsfiles to platform so that proposals can be accessed by shared process.Extensions can lock the proposal version by mentioning the version while declaring the proposal in
enabledApiProposalssection. Locking the version should make the extension installable or activated in VS Code with the proposal with that version number only. This PR does not have this installation or activation validation which will be implemented in next PR.enabledApiProposalNamesproperty inIExtensionDescriptionthat contains parsedenabledApiProposals. This should be used byExtensionsProposedAPIfor validation and modification.