Allow the QuickInput widget to be dragged #237534
Merged
+236
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @lszomoru for the initial prototype! That also had resizing but there were a couple edge cases that made it not quite ready. However, the drag-n-drop is really quite polished so I wanted to get this out for folks to try and I don't think it needs a setting. Next steps: * Add a snap to the top (aka the original location) * Resize... Fixes #17268
karthiknadig
approved these changes
Jan 9, 2025
songjianet
approved these changes
Jan 9, 2025
|
Very cool 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @lszomoru for the initial prototype! That also had resizing but there were a couple edge cases that made it not quite ready.
I'm not sold on the grid lines. On macOS Spotlight just snaps, there's no grid. But let's keep it for now, it's easy to remove.
However, the drag-n-drop is really quite polished so I wanted to get this out for folks to try and I don't think it needs a setting.
Next steps:
Fixes #17268