Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UWP testhost deps in meta package #1351

Merged
merged 6 commits into from
Jan 3, 2018
Merged

Add UWP testhost deps in meta package #1351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0300647
Add UWP testhost deps in meta package
smadala Dec 29, 2017
f84feae
Add dependecies as min versions
smadala Jan 2, 2018
503775a
Make Netwonsoft json version as variable
smadala Jan 2, 2018
bc52e0e
nit fix
smadala Jan 2, 2018
5aee3e8
Use JsonNetVersion in translationlayer.nuspec
smadala Jan 2, 2018
20cd2ed
Merge branch 'master' into uwp-meta-pkg
smadala Jan 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/package/nuspec/Microsoft.NET.Test.Sdk.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,24 @@
<requireLicenseAcceptance>true</requireLicenseAcceptance>
<licenseUrl>http://www.microsoft.com/web/webpi/eula/net_library_eula_enu.htm</licenseUrl>
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<description>The MSbuild targets and properties for building the .Net core test projects.</description>
<description>The MSbuild targets and properties for building .NET Core, .NET Full framework and Universal Windows test projects.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest: .NET test projects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
<dependencies>
<dependency id="Microsoft.TestPlatform.TestHost" version="$Version$" />
<dependency id="Microsoft.CodeCoverage" version="1.0.3" />
<group targetFramework="uap10.0">
<dependency id="System.ComponentModel.Primitives" version="4.1.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we choose to not provide TestHost in section? CodeCoverage is not provided because it's not supported in UWP yet.

A comment in here may help our future selves :)

Copy link
Contributor

@mayankbansal018 mayankbansal018 Dec 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not hardcode any version, set them as min version. You can look at objectmodel nuspec, there we specify min version of dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<dependency id="System.ComponentModel.TypeConverter" version="4.1.0" />
<dependency id="System.Runtime.InteropServices.RuntimeInformation" version="4.0.0" />
<dependency id="Newtonsoft.Json" version="9.0.1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NewtonSoft.Json is also needed by TestHost. How do we keep versions in sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using JsonNetVersion from TestPlatform.Dependencies.props.

</group>
<group targetFramework="netcoreapp1.0">
<dependency id="Microsoft.TestPlatform.TestHost" version="$Version$" />
<dependency id="Microsoft.CodeCoverage" version="1.0.3" />
</group>
<group targetFramework="net45">
<dependency id="Microsoft.CodeCoverage" version="1.0.3" />
</group>
</dependencies>
</metadata>
<files>
Expand Down
2 changes: 1 addition & 1 deletion src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<tags>vstest visual-studio unittest testplatform mstest microsoft</tags>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
</metadata>
<files>
<!-- Add a third party notice file -->
Expand Down
2 changes: 1 addition & 1 deletion src/package/nuspec/Microsoft.TestPlatform.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<tags>vstest visual-studio unittest testplatform mstest microsoft</tags>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
</metadata>
<files>
<!-- Add a third party notice file -->
Expand Down
1 change: 1 addition & 0 deletions src/package/nuspec/TestPlatform.Build.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching for packages with test shows 1042 packages and testing lists 1045. While we're at it, maybe add testing as well. I wish it were easier to find and add tags from nuget ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

</metadata>
<files>
<file src="Microsoft.TestPlatform.Build\netstandard1.3\Microsoft.TestPlatform.targets" target="runtimes\any\native" />
Expand Down
1 change: 1 addition & 0 deletions src/package/nuspec/TestPlatform.CLI.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
<contentFiles>
<files include="**/*.*" copyToOutput="true" flatten="false" buildAction="None" />
</contentFiles>
Expand Down
1 change: 1 addition & 0 deletions src/package/nuspec/TestPlatform.ObjectModel.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
<dependencies>
<group targetFramework="net451">
<dependency id="System.Runtime.InteropServices.RuntimeInformation" version="[4.3.0, )" />
Expand Down
1 change: 1 addition & 0 deletions src/package/nuspec/TestPlatform.TestHost.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
<dependencies>
<group targetFramework="netcoreapp1.0">
<dependency id="Microsoft.TestPlatform.ObjectModel" version="$Version$"/>
Expand Down
1 change: 1 addition & 0 deletions src/package/nuspec/TestPlatform.TranslationLayer.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl>
<projectUrl>https://github.com/microsoft/vstest/</projectUrl>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
<tags>vstest visual-studio unittest testplatform mstest microsoft test</tags>
<dependencies>
<group targetFramework="net451">
<dependency id="Newtonsoft.Json" version="9.0.1"/>
Expand Down