Make a lot of experimental things release #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
reviewed
May 17, 2021
| @@ -11,15 +11,12 @@ public class ImportCommand : BaseCommand | |||
| [SetUp] | |||
| public void Setup() | |||
| { | |||
| InitializeAllFeatures(false); | |||
| ConfigureFeature("export", true); | |||
| CleanupTestExe(); | |||
| } | |||
|
|
|||
| [TearDown] | |||
| public void TearDown() | |||
There was a problem hiding this comment.
Applies to the other 2 tests' setup and teardown if you decide to do so
yao-msft
reviewed
May 17, 2021
| // While DO still requires an explicit opt-in, we will let failures through. | ||
| // When DO becomes the default, we may choose to catch exceptions and fall back to WinINet below. | ||
| // If DO becomes an issue, we may choose to catch exceptions and fall back to WinINet below. | ||
| // We would need to be careful not to bypass metered networks or other reasons that might |
This was
linked to
issues
May 18, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Make
list,upgrade,uninstall, andexportcommands no longer experimental. Also make the REST source implementation not experimental, as well as making Delivery Optimization the default downloader.Microsoft Reviewers: Open in CodeFlow