Parse start and end line numbers as numbers, not strings #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weirdly seemed to have missed this due to copy/pasting the I’ll review and merge tomorrow, when back @ 💻. :) |
mauricedb
force-pushed
the
Issue-34-string-line-numbers
branch
from
046a9ad to
cad6972
Compare
|
@mixn Oops, sorry for the typo. Fixed. |
mixn
approved these changes
Oct 14, 2018
|
Thanks again @mauricedb, nice catch! ✋ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
--startand--endcan fail the check that the end line is larger than the start line because the comparison is done using strings instead of the numerical value.Fixes #34