Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Add RoomEnvironment to alpha hash example #26344

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

donmccurdy
Copy link
Collaborator

@WestLangley
Copy link
Collaborator

WestLangley commented Jun 28, 2023

This is what I got when I set roughness to 0.2.

Screenshot 2023-06-28 at 1 52 40 PM

Also, if you are using RoomEnvironment, I would expect to see tone mapping and exposure set.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 28, 2023

Do you mind setting the useLegacyLights flag to false like in all other examples?

@mrdoob mrdoob added this to the r154 milestone Jun 29, 2023
@donmccurdy
Copy link
Collaborator Author

Do you mind setting the useLegacyLights flag to false like in all other examples?

Done. 👍

if you are using RoomEnvironment, I would expect to see tone mapping and exposure set.

While I agree on the importance of tone mapping in any lit scene, I'm not sure that I'm supportive of putting ACES Filmic on all of our examples as a default (or our other current tone mapping choices, for that matter). If that is the proposed direction, perhaps we can discuss in a new thread?

@donmccurdy
Copy link
Collaborator Author

It seems the CI is failing on this example. Perhaps the alpha hashing is non-deterministic across GPUs? I've added it to the exception list for now.

@mrdoob mrdoob merged commit 21e57f6 into mrdoob:dev Jun 29, 2023
@donmccurdy donmccurdy deleted the examples/alphahash-roomenvironment branch June 29, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants