Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorManagement: Support treeshake. #29816

Merged
merged 2 commits into from
Nov 6, 2024
Merged

ColorManagement: Support treeshake. #29816

merged 2 commits into from
Nov 6, 2024
+130 −122

Conversation

linbingquan
Copy link
Contributor

Related issue: #29815

Description

As the title says.

If the PR has any problem, please tell me.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.21
171.45		 692.24
171.45		 +26 B
+0 B
WebGPU 821.89
221.91		 821.91
221.92		 +26 B
+15 B
WebGPU Nodes 821
221.7		 821.03
221.72		 +26 B
+20 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.56
112.27		 464.58
112.26		 +26 B
-7 B
WebGPU 542.09
146.75		 542.12
146.75		 +26 B
-5 B
WebGPU Nodes 498.03
136.5		 498.06
136.5		 +26 B
+5 B

donmccurdy
donmccurdy approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Mugen87 Mugen87 merged commit d82b592 into mrdoob:dev Nov 6, 2024
12 checks passed
@Mugen87 Mugen87 added this to the r171 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r171
Development

Successfully merging this pull request may close these issues.
3 participants
@linbingquan @donmccurdy @Mugen87