Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: convertToTexture() - return pass() texture if available #29957

Merged
merged 1 commit into from
Nov 25, 2024
Merged

TSL: convertToTexture() - return pass() texture if available #29957

merged 1 commit into from
Nov 25, 2024
+9 −1

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 25, 2024

Related issue: Closes #29851

Description

Returns the texture automatically if the input is a pass().

@sunag sunag added this to the r171 milestone Nov 25, 2024
@sunag sunag marked this pull request as ready for review November 25, 2024 03:14
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.14
78.99		 339.14
78.99		 +0 B
+0 B
WebGPU 483.12
134.14		 483.15
134.15		 +32 B
+11 B
WebGPU Nodes 482.58
134.04		 482.62
134.06		 +32 B
+11 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.59
111.96		 464.59
111.96		 +0 B
+0 B
WebGPU 552.25
149.49		 552.25
149.49		 +0 B
+0 B
WebGPU Nodes 508.13
139.2		 508.13
139.2		 +0 B
+0 B

@sunag sunag merged commit 54ce779 into mrdoob:dev Nov 25, 2024
12 checks passed
@sunag sunag deleted the dev-improve-convertToTexture branch November 25, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r171
Development

Successfully merging this pull request may close these issues.

WebGPURenderer: incorrect texture dimensions in shaders
1 participant
@sunag