Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptableNode: Clean up. #30159

Merged
merged 1 commit into from
Dec 18, 2024
Merged

ScriptableNode: Clean up. #30159

merged 1 commit into from
Dec 18, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 18, 2024

Related issue: #30158

Description

Minor clean up in ScriptableNode.

@Mugen87 Mugen87 added this to the r172 milestone Dec 18, 2024
@Mugen87 Mugen87 merged commit b70db2a into mrdoob:dev Dec 18, 2024
10 of 11 checks passed
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.4
79.05
339.4
79.05
+0 B
+0 B
WebGPU 486.51
134.96
486.51
134.96
+0 B
+0 B
WebGPU Nodes 485.98
134.87
485.98
134.87
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 555.65
150.41
555.65
150.41
+0 B
+0 B
WebGPU Nodes 511.54
140.14
511.54
140.14
+0 B
+0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant