Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popups] Rename onCloseComplete to onOpenChangeComplete #1305

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[popups] Rename onCloseComplete to onOpenChangeComplete #1305

wants to merge 6 commits into from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jan 8, 2025

Closes #1208

New alternative to #1235 to support both symmetric open/close cases, which has a more intuitive API.

  • Reworks useAfterExitAnimation to support both open/close animations
  • onOpenChangeComplete is called with open: boolean

@mui-bot
Copy link

mui-bot commented Jan 8, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-1305--base-ui.netlify.app/

Generated by 🚫 dangerJS against 30d8bad

@atomiks atomiks mentioned this pull request Jan 8, 2025
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite will be requested when the pull request is marked ready for review colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak will be requested when the pull request is marked ready for review michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dialog, Popover] Provide a callback for open/close completion
2 participants
@atomiks @mui-bot