Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Progress] Add format prop and Progress.Value #989

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Progress] Add format prop and Progress.Value #989

wants to merge 3 commits into from
+405 −45

Conversation

mj12albert
Copy link
Member

Part of #961

@mj12albert mj12albert added the component: progress This is the name of the generic UI component, not the React module! label Dec 9, 2024
@mj12albert mj12albert mentioned this pull request Dec 9, 2024
Closed
1 task
@mui-bot
Copy link

mui-bot commented Dec 9, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-989--base-ui.netlify.app/

Generated by 🚫 dangerJS against 25a3634

@mj12albert mj12albert force-pushed the feat/format-progress branch 2 times, most recently from c57e0f2 to 51ad30e Compare December 9, 2024 10:20
@mj12albert mj12albert marked this pull request as ready for review December 9, 2024 10:25
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 10, 2024
@atomiks
Copy link
Contributor

atomiks commented Dec 26, 2024

Is this in need of reviewing? It's a bit out of date

The Value component isn't listed on the Progress docs

@mj12albert
Copy link
Member Author

Is this in need of reviewing? It's a bit out of date
The Value component isn't listed on the Progress docs

Yes it is, though Colm said to leave out the Value just before the public release, is this ok to add now @colmtuite ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: progress This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj12albert @mui-bot @atomiks