Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fips): update harvest and packaging tests to run for fips packages #1980

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(fips): update harvest and packaging tests to run for fips packages #1980

merged 1 commit into from
Jan 9, 2025
+264 −149

Conversation

rajrohanyadav
Copy link
Contributor

@rajrohanyadav rajrohanyadav commented Dec 31, 2024 •
edited
Loading

Description

  • Update harvest tests for running on FIPS hosts
  • Update packaging tests for running on FIPS hosts

Testing

@rajrohanyadav rajrohanyadav force-pushed the NR-268778-add-fips-tests branch from 088df9f to 178c229 Compare December 31, 2024 06:53
@coveralls
Copy link

coveralls commented Dec 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12670090243

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 57.377%
Files with Coverage Reduction New Missed Lines %
pkg/metrics/sampler/sampler_routine.go 2 95.35%
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 12669660022: 0.03%
Covered Lines: 15373
Relevant Lines: 26793
💛 - Coveralls

@rajrohanyadav rajrohanyadav force-pushed the NR-268778-add-fips-tests branch 6 times, most recently from 091940e to 5006b6a Compare January 2, 2025 12:23
@rajrohanyadav rajrohanyadav marked this pull request as ready for review January 2, 2025 12:28
@rajrohanyadav rajrohanyadav requested a review from a team as a code owner January 2, 2025 12:28
@rajrohanyadav rajrohanyadav force-pushed the NR-268778-add-fips-tests branch 2 times, most recently from 432fc75 to 7f36493 Compare January 3, 2025 10:04
@rajrohanyadav rajrohanyadav force-pushed the NR-268778-add-fips-tests branch 4 times, most recently from 89b2420 to b886966 Compare January 8, 2025 10:00
@rajrohanyadav rajrohanyadav changed the title feat(fips): update harvest tests to run for fips packages feat(fips): update harvest and packaging tests to run for fips packages Jan 8, 2025
@rajrohanyadav rajrohanyadav force-pushed the NR-268778-add-fips-tests branch 2 times, most recently from a9f00c3 to 60e3503 Compare January 8, 2025 11:30
@rajrohanyadav
feat(fips): update tests to run for fips packages
0aaa822 
* update harvest tests to run for fips packages
* chore: update action versions
* update packaging tests
* assume role for 2 hours as tests can take longer than 1 hour
@rajrohanyadav rajrohanyadav force-pushed the NR-268778-add-fips-tests branch from 60e3503 to 0aaa822 Compare January 8, 2025 11:58
alvarocabanas
alvarocabanas approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@alvarocabanas alvarocabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

test/packaging/ansible/test.yml
import_playbook: shutdown-and-terminate.yml
when: "'al-2023' not in inventory_hostname" # TODO: https://new-relic.atlassian.net/browse/NR-282854 AL-2023 fails this test 80% of the time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rajrohanyadav rajrohanyadav merged commit 2cd4baa into feat/fips Jan 9, 2025
22 checks passed
@rajrohanyadav rajrohanyadav deleted the NR-268778-add-fips-tests branch January 9, 2025 03:55
rajrohanyadav added a commit that referenced this pull request Jan 9, 2025
@rajrohanyadav
feat(fips): update tests to run for fips packages (#1980)
aa44252 
* update harvest tests to run for fips packages
* chore: update action versions
* update packaging tests
* assume role for 2 hours as tests can take longer than 1 hour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarocabanas alvarocabanas alvarocabanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajrohanyadav @coveralls @alvarocabanas