lib, path: support file:/// urls in path functions

[avivkeller]

This PR adjusts the builtin path functions to support file:/// URLs.

Related to: #49273
Related to: #41521

[avivkeller]

Okay, now the linting should pass

[aduh95]

The docs and tests should also be updated.

[avivkeller]

The docs and tests should also be updated.

Will do!

[avivkeller]

What semver will this be, so I can update the docs with the change version?

[avivkeller]

I didn't modify the YAML specs, but I did update the docs. I will re-lint this and update the tests shortly

[avivkeller]

Docs are ready, but the tests are kind of a mess, so once I figure out where to add them, I will.

[avivkeller]

I'll check out the build issues when I get a chance

[LiviaMedeiros]

What semver will this be, so I can update the docs with the change version?

The version for YAML changelog must be REPLACEME, like this:

changes:
  - version: REPLACEME
    pr-url: https://github.com/nodejs/node/pull/52497
    description: Added `URL` support

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-3-code

[avivkeller]

What semver will this be, so I can update the docs with the change version?

The version for YAML changelog must be REPLACEME, like this:

changes:

  - version: REPLACEME

    pr-url: https://github.com/nodejs/node/pull/52497

    description: Added `URL` support

Will do, thank you!

[avivkeller]

The checks have this issue:

TypeError: path.resolve is not a function
    at pathToFileURL (node:internal/url:1532:23)
    at evalScript (node:internal/process/execution:82:19)
    at node:internal/main/eval_string:51:3

I'll do some investigating

[avivkeller]

The checks have this issue:

TypeError: path.resolve is not a function
    at pathToFileURL (node:internal/url:1532:23)
    at evalScript (node:internal/process/execution:82:19)
    at node:internal/main/eval_string:51:3

I'll do some investigating

I did some testing, and I'm not sure what's causing this. AFAICT the resolve function is defined

[himself65]

The checks have this issue:

TypeError: path.resolve is not a function
    at pathToFileURL (node:internal/url:1532:23)
    at evalScript (node:internal/process/execution:82:19)
    at node:internal/main/eval_string:51:3

I'll do some investigating

I did some testing, and I'm not sure what's causing this. AFAICT the resolve function is defined

it seems like there is a circular dependency.

[avivkeller]

:-/ okay, that puts some dents in the implementation. I'll sort it out tomorrow (EST).

[avivkeller]

It is a circular dependency because path.resolve is used in the function we are trying to use in path.resolve. It's not worth it to re-implement the entire system just for this, so I'm stumped. Does anyone have any ideas?

[avivkeller]

Ignore the reference, wrong issue

[himself65]

use lazy load, you might found such code in other files

[avivkeller]

I can try it, but I'm worried that (and this might be completely incorrect) once the lazyloading is complete, then it will throw a circular dependency errro

[avivkeller]

Temporarily moving to draft state, as changes in #52509 will be applied to this PR (if that one is merged)

[avivkeller]

Blocked by #52509

[avivkeller]

Given the conflicts, I am closing this PR, and I will open a new one sometime this week.