Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Use limited range for R10l output #11695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpark37
Copy link
Collaborator

@jpark37 jpark37 commented Jan 2, 2025

Description

DeckLink hardware seems to want the values in video range.

Motivation and Context

The scopes on my fancy display were showing bad values were being sent over the wire.

Values being between 64 and 940 for bmdFormat10BitRGBXLE don't seem to be in the DeckLink SDK PDF, but they are in code comments of Mac/Linux DeckLinkAPIModes.h and Windows DeckLinkAPIModes.idl.

How Has This Been Tested?

Scopes on my display show proper values are being sent over the wire.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

DeckLink hardware seems to want the values in video range.
@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Jan 4, 2025
@PatTheMav
Copy link
Member

Is R10L a Decklink-exclusive format (as in: OBS will never be faced with R10L data coming from anything but the Decklink SDK)?

@jpark37
Copy link
Collaborator Author

jpark37 commented Jan 7, 2025

Google shows it's probably specific to DeckLink. I think I was lazy and the code was originally for default effect when I added the HDR shader technique. Maybe someone can move to a plugin-specific effect file another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants