Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-ffmpeg: Fix throughput checks for older AMD driver #11710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhutsAMD
Copy link
Contributor

@rhutsAMD rhutsAMD commented Jan 8, 2025

Description

This PR fixes the case where OBS does not refresh the throughput caps with the user's setting so stale throughput values are used to check preset compatibility as well as the case where ..._CAP_MAX_THROUGHPUT does not work as expected -> returns 0 -> and fails to fall back to the lowest preset.

Motivation and Context

This is a bug fix.

How Has This Been Tested?

  • Tested on multiple Windows machines

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant