forked from github/gh-ost
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copying AUTO_INCREMENT value to ghost table #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use sync.Once to avoid to send drop cutover sentry table to mysql twice (merge PR)
Parsing ipv6 addresses
Support Azure Database for MySQL (merge PR)
Use golang:1.15.x, remove jessie tarball build
Initial commit: towards setting up a test suite Signed-off-by: Shlomi Noach <[email protected]>
…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
This PR now:
|
shlomi-noach
changed the title
WIP: copying AUTO_INCREMENT value to ghost table
Copying AUTO_INCREMENT value to ghost table
Dec 31, 2020
2 tasks
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit: towards setting up a test suite
Solves github#381
Description
This PR ensures to copy
AUTO_INCREMENT
value togh-ost
table. The problem in github#381 is that if rows are deleted from end of table, then the new table is created (or ends up) with a lower auto_increment value. I think most migrations do not encounter this issue because new rows are commonly added to the table while it's being migrated, naturally bumping up the ghost table'sAUTO_INCREMENT
value to match the original table's. But for static tables this can happen.script/cibuild
returns with no formatting errors, build errors or unit test errors.