-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-5354: Backup is failing on validation PartiallyFailed #86780
base: main
Are you sure you want to change the base?
OADP-5354: Backup is failing on validation PartiallyFailed #86780
Conversation
@anarnold97: This pull request references OADP-5354 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "OADP 1.4.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@anarnold97: This pull request references OADP-5354 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "OADP 1.4.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label oadp |
@anarnold97: This pull request references OADP-5354 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "OADP 1.4.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
EOF | ||
$ oc -n openshift-adp create secret generic cloud-credentials \ | ||
--from-file=${SCRATCH}/credentials | ||
---- | ||
|
||
+ | ||
<1> <aws-region> is the AWS region in which the cloud resources has been created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything you want us to add?
Or do you want us to adapt the AWS content -
A Regional endpoint is the URL of the entry point within a particular region for an AWS web
service.
AWS recommends using Regional AWS Security Token Service (AWS STS) endpoints instead of the
global endpoint to reduce latency, build in redundancy, and increase session token validity.
LGTM, @kaovilai wdyt? |
@@ -160,11 +160,13 @@ $ cat <<EOF > ${SCRATCH}/credentials | |||
[default] | |||
role_arn = ${ROLE_ARN} | |||
web_identity_token_file = /var/run/secrets/openshift/serviceaccount/token | |||
region=<aws_region> # <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhardesty - are you ok for me to make this change to your ROSA docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anarnold97 LGTM; however, these cloud expert tutorials are maintained by the MOBB team. I would check with them first. @michaelryanmcneill do you know who can verify this doc change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small nits. Otherwise LGTM!
cloud_experts_tutorials/cloud-experts-deploy-api-data-protection.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: A.Arnold <[email protected]>
84df3ee
to
1af3274
Compare
@anarnold97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
JIRA
Version(s):
OADP 1.3 is still supported, which is why 4.12 is required
Issue:
Link to docs preview:
QE review:
Additional information: