Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-5354: Backup is failing on validation PartiallyFailed #86780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Jan 7, 2025

JIRA

Version(s):

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18

OADP 1.3 is still supported, which is why 4.12 is required

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@anarnold97: This pull request references OADP-5354 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "OADP 1.4.0" instead.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@anarnold97: This pull request references OADP-5354 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "OADP 1.4.0" instead.

In response to this:

JIRA

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@anarnold97: This pull request references OADP-5354 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "OADP 1.4.0" instead.

In response to this:

JIRA

Version(s):

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18

OADP 1.3 is still supported, which is why 4.12 is required

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

EOF
$ oc -n openshift-adp create secret generic cloud-credentials \
--from-file=${SCRATCH}/credentials
----

+
<1> <aws-region> is the AWS region in which the cloud resources has been created.
Copy link
Contributor Author

@anarnold97 anarnold97 Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything you want us to add?

Or do you want us to adapt the AWS content -

A Regional endpoint is the URL of the entry point within a particular region for an AWS web 
service. 

AWS recommends using Regional AWS Security Token Service (AWS STS) endpoints instead of the 
global endpoint to reduce latency, build in redundancy, and increase session token validity.

@weshayutin
Copy link

LGTM, @kaovilai wdyt?

@@ -160,11 +160,13 @@ $ cat <<EOF > ${SCRATCH}/credentials
[default]
role_arn = ${ROLE_ARN}
web_identity_token_file = /var/run/secrets/openshift/serviceaccount/token
region=<aws_region> # <1>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhardesty - are you ok for me to make this change to your ROSA docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anarnold97 LGTM; however, these cloud expert tutorials are maintained by the MOBB team. I would check with them first. @michaelryanmcneill do you know who can verify this doc change?

Copy link
Contributor

@shdeshpa07 shdeshpa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small nits. Otherwise LGTM!

modules/installing-oadp-rosa-sts.adoc Outdated Show resolved Hide resolved
@anarnold97 anarnold97 force-pushed the OADP-5354-Backup-is-failing-on-validation-PartiallyFailed branch from 84df3ee to 1af3274 Compare January 8, 2025 09:49
Copy link

openshift-ci bot commented Jan 8, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OADP Label for all OADP PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants