Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-hs: init script does not handle boolean correctly #25640

Open
codekow opened this issue Dec 29, 2024 · 1 comment
Open

tor-hs: init script does not handle boolean correctly #25640

codekow opened this issue Dec 29, 2024 · 1 comment

Comments

@codekow
Copy link

codekow commented Dec 29, 2024

The package luci-app-tor uses 0 or 1 to set Enabled (other packages follow the same pattern).

The following should keep compatibility with using true or false or 1 or 0.

Issue

tor-hs init script does not run hook script when:

config hidden-service
     option Enabled '1'

config_get enable_hs "$config" Enabled 0

if [ "$enable_hs" = "true" ] && [ -x "$hook_script" ] && [ -f "$hostname" ] ; then

@codekow
Copy link
Author

codekow commented Jan 2, 2025

See #21642
See #25162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant