Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tor-hs.init hs hook processing #25641

Closed
wants to merge 4 commits into from

Conversation

codekow
Copy link

@codekow codekow commented Dec 29, 2024

Maintainer: Jan Pavlinec [email protected]
Compile tested: NA
Run tested: 23.05.5

Description:

See #25640

Signed-off-by: Cory Latschkowski <[email protected]>
@codekow
Copy link
Author

codekow commented Dec 29, 2024

See #25640

@mhei
Copy link
Member

mhei commented Dec 30, 2024

Thanks for your contribution. I think you should squash the fixes into a single commit and list the changes in commit description. Please also review our contribution notes to get the PR in shape regarding commit title and so on. And I'm a little bit confused: this PR is against master, but you tested 23.05.5? To be honest, I'm not familiar with this package and don't know how big the difference is between master and the mentioned release, so I'm just wondering whether testing master is required?

@mhei
Copy link
Member

mhei commented Dec 30, 2024

I just stumpled over #25162 which might conflict with this one here? Did not check in detail though...

@codekow
Copy link
Author

codekow commented Jan 2, 2025

@mhei Thanks for the info.

I'm new to some of the development here so I'm trying to understand how to do PRs for this project. Since it's a script it would apply to all release versions. I wasn't sure if I should start with master or a specific branch. I'll reread the contributor docs.

I'll check #25162

@codekow
Copy link
Author

codekow commented Jan 2, 2025

@mhei Thanks again - I'll do a better job looking for existing PRs.

@codekow codekow closed this Jan 2, 2025
@mhei
Copy link
Member

mhei commented Jan 2, 2025

@codekow : No problem - you're welcome. Due to the amount of PR it is not always easy to be aware of all :-)
BTW: Usually the PR are first made against main/master, then a backport PR (cherry-picking) is done against releases where relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants