-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tor-hs.init hs hook processing #25641
Conversation
Signed-off-by: Cory Latschkowski <[email protected]>
See #25640 |
cef90cb
to
2180fdb
Compare
Signed-off-by: Cory Latschkowski <[email protected]>
Signed-off-by: Cory Latschkowski <[email protected]>
Signed-off-by: Cory Latschkowski <[email protected]>
Thanks for your contribution. I think you should squash the fixes into a single commit and list the changes in commit description. Please also review our contribution notes to get the PR in shape regarding commit title and so on. And I'm a little bit confused: this PR is against master, but you tested 23.05.5? To be honest, I'm not familiar with this package and don't know how big the difference is between master and the mentioned release, so I'm just wondering whether testing master is required? |
I just stumpled over #25162 which might conflict with this one here? Did not check in detail though... |
@mhei Thanks for the info. I'm new to some of the development here so I'm trying to understand how to do PRs for this project. Since it's a script it would apply to all release versions. I wasn't sure if I should start with master or a specific branch. I'll reread the contributor docs. I'll check #25162 |
@mhei Thanks again - I'll do a better job looking for existing PRs. |
@codekow : No problem - you're welcome. Due to the amount of PR it is not always easy to be aware of all :-) |
Maintainer: Jan Pavlinec [email protected]
Compile tested: NA
Run tested: 23.05.5
Description:
See #25640