Introduce yarn.lock -> bun.lock{b} migrator #16166
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 10:07 AM PT - Jan 4th, 2025
❌ @Jarred-Sumner, your commit e7508db has 1 failures in
🧪 try this PR locally: bunx bun-pr 16166 |
paperclover
reviewed
Jan 6, 2025
| }; | ||
|
|
||
| // Helper to process dependencies from a map | ||
| const processDeps = struct { |
There was a problem hiding this comment.
why is this function wrapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Once complete, this will make
bun installautomatically migrate yarn.lock files to bun.lock, preserving versions.The parser part is written and seems like it works. It does load dependencies from yarn.lock. It does not actually do the most important part, which is preserve versions - but that's likely because it seems like we need to read package.json to disambiguate which top-level dependencies are the root package's dependencies.
How did you verify your code works?
I copied npm's test fixtures, which will be used for tests. Thanks @isaacs