Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for network NBT. #110

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Add tests for network NBT. #110

merged 2 commits into from
Apr 9, 2024

Conversation

occanowey
Copy link
Contributor

Some tests for networked NBT as discussed in #109.

I decided not to add a test for deserializing a named root tag with a network deserializer because it's kinda always going to do some funny behavior. e.g. if the name length is less than 255 it will just read it as an empty compound or if the name is greater than 255 it'll try read the first byte as a type and go down hill from there.

@owengage
Copy link
Owner

owengage commented Apr 9, 2024

Brilliant, thanks. 😊

@owengage owengage merged commit d2653e3 into owengage:master Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants