Use CircleCI template with JDK 11 #619
Conversation
Generate changelog in
|
| build-ibm: | ||
| docker: [{ image: 'ellisjoe/ibm-java-openssl:java-8' }] | ||
| resource_class: xlarge | ||
| trial-publish: | ||
| docker: [{ image: 'cimg/openjdk:11.0.10-node' }] | ||
| resource_class: medium | ||
| environment: | ||
| GRADLE_OPTS: -Dorg.gradle.console=plain -Dorg.gradle.internal.launcher.welcomeMessageEnabled=false | ||
|
|
||
| CIRCLE_TEST_REPORTS: /home/circleci/junit | ||
| CIRCLE_ARTIFACTS: /home/circleci/artifacts | ||
| GRADLE_OPTS: -Dorg.gradle.workers.max=1 -Dorg.gradle.jvmargs='-Xmx2g --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED' | ||
| _JAVA_OPTIONS: -XX:ActiveProcessorCount=2 -XX:MaxRAM=4g -XX:ErrorFile=/home/circleci/artifacts/hs_err_pid%p.log -XX:HeapDumpPath=/home/circleci/artifacts | ||
| steps: | ||
| - checkout | ||
| - restore_cache: { key: 'gradle-wrapper-{{ checksum "gradle/wrapper/gradle-wrapper.properties" }}' } | ||
| - restore_cache: { key: 'gradle-cache-{{ checksum "versions.props" }}-{{ checksum "build.gradle" }}' } | ||
| - run: ./gradlew --no-daemon --parallel --continue crypto-core:test |
There was a problem hiding this comment.
Note that we previously tested against IBM JDK 8 using the container image from https://github.com/ellisjoe/ibm-java-openssl/blob/develop/Dockerfile, but that has not been migrated over. We could potentially sudo apt install adoptopenjdk-11-openj9 and test against that, but would prefer to defer that for another day.
There was a problem hiding this comment.
I'm fine no longer testing against the IBM JVM. I'm not aware of any usage and the overhead of maintaining that additional test has been quite high.
|
once this is approved, we'll need to adjust the required checks for repo to |
|
🚀 |
Before this PR
The circleci setup was using a custom JDK 8 container image with openssl added to enable testing with Hadoop native library crypto. Unfortunately, the custom circle config is causing a bunch of stuck excavators due to Gradle infrastructure requiring JDK 11.
See:
After this PR
==COMMIT_MSG==
Use CircleCI template with JDK 11
==COMMIT_MSG==
Possible downsides?
Does not setup & test IBM JDK yet