Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it compatible with gcc 4.8 #150

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Making it compatible with gcc 4.8 #150

merged 1 commit into from
Jul 15, 2020

Conversation

rafadesu
Copy link
Contributor

There is an inline function that assumes the compiler has copy elision
optimization which is actually not required until C++17. GCC 4.8 does it
but it requires the copy constructor to be defined which is not the case
for std::ifstream. Fixed by passing reference by parameter.

There is an inline function that assumes the compiler has copy elision
optimization which is actually not required until C++17. GCC 4.8 does it
but it requires the copy constructor to be defined which is not the case
for std::ifstream. Fixed by passing reference by parameter.
@rafadesu
Copy link
Contributor Author

Congratulations on such a great library.
Unfortunately, we are stuck with c++4.8 at the moment for the project we would like to use it in and this is the only problem it has while compiling. I'd appreciate if you considered this change so we don't have to patch or use a fork.
By the way, what are the plans to create a new release? It looks like a very long time since the previous one was created.

@pantor
Copy link
Owner

pantor commented Jul 15, 2020

Thanks for your PR, it looks good to me.

I‘ll probably release version 3.0 very soon, but I want to add a few more unit tests.

@pantor pantor merged commit 17175f7 into pantor:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants