Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings for Clang and MSVC #197

Merged
merged 4 commits into from
May 20, 2021

Conversation

WimLeflere
Copy link
Contributor

Fix some build warnings for Clang and MSVC.

  • unnecessary semicolons
  • missing virtual desctructor
  • implicit conversion from double to int

At the moment I have to disable some warnings when inja is included.
It would be nice if this is no longer needed.

#ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable : 4244)
#else
#pragma clang diagnostic push
#pragma clang diagnostic warning "-Wextra-semi"
#pragma clang diagnostic warning "-Wnon-virtual-dtor"
#endif
#include <inja/inja.hpp>
#ifdef _MSC_VER
#pragma warning(pop)
#else
#pragma clang diagnostic pop
#endif

@pantor pantor merged commit b4b9d8d into pantor:master May 20, 2021
@pantor
Copy link
Owner

pantor commented May 20, 2021

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants