Add variables index, index1, is_first and is_last to object loops #52
Conversation
The special variables `index`, `index1`, `is_first` and `is_last` are available in loops over arrays. Add these variables so they available in loops over objects
| data_loop[element_loop->value] = item.second; | ||
| result.append( render(Template(*element_loop), data_loop) ); | ||
| /* For nested loops, use parent/index */ | ||
| if (data_loop.count("index") == 1 && data_loop.count("index1") == 1) { |
There was a problem hiding this comment.
Why does not to follow the jinja2 specs and not to put all these variables inside the 'loop' composite variable? In this case user can refer this vars as loop.index, loop.index1 etc. and can avoid situations like this:
{% for index in indexes %} {{ index }} {% endfor %}
Which 'index' should be used here?
There was a problem hiding this comment.
Good question. I'm not familiar with jinja2 - I just followed the existing construct that inja uses for loops over arrays. However, your suggestion should be relatively straightforward to implement.
That said, I don't know how closely inja in intended to follow jinja2 specs - the inja readme says 'loosely inspired'. I would defer to the opinion of @pantor in this case.
There was a problem hiding this comment.
Yes. I see. So waiting for @pantor decision. But here is one more reason to use 'loop' variable instead of several different vars. In case of 'loop' var you can simplify this piece of code in the following way:
if (data.count("loop") == 1)
{
data_loop["loop"]["parent"] = data["loop"];
}
data_loop["loop"]["index"] = ...;
// ...And as a consequence you can access any outer loop context as {{ loop.parent.parent.index }}.
There was a problem hiding this comment.
Yep, I think we should follow the jinja2 spec in this (and in general more) cases. I'll update the master branch to use the loop variable, and then feel free to update this PR, @craigpepper. Thanks so much!
The special variables
index,index1,is_firstandis_lastare available in loops over arrays. Add these variables so they available in loops over objects