[Fix] ensure ES3 Number constants don’t get lost in ES3 browsers.

Fixes #402.
paulmillr · Jan 27, 2016 · 1a6941f · 1a6941f
1 parent 78e307c
commit 1a6941f
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/es6-shim.js b/es6-shim.js
@@ -1397,6 +1397,14 @@
       return NumberShim;
     }());
     wrapConstructor(OrigNumber, NumberShim, {});
+    // this is necessary for ES3 browsers, where these properties are non-enumerable.
+    defineProperties(NumberShim, {
+      NaN: OrigNumber.NaN,
+      MAX_VALUE: OrigNumber.MAX_VALUE,
+      MIN_VALUE: OrigNumber.MIN_VALUE,
+      NEGATIVE_INFINITY: OrigNumber.NEGATIVE_INFINITY,
+      POSITIVE_INFINITY: OrigNumber.POSITIVE_INFINITY
+    });
     /* globals Number: true */
     /* eslint-disable no-undef */
     /* jshint -W020 */

diff --git a/test/number.js b/test/number.js
@@ -64,6 +64,36 @@ describe('Number', function () {
       expect(Number.propertyIsEnumerable('EPSILON')).to.equal(false);
       expect(Number.EPSILON).to.equal(2.2204460492503130808472633361816e-16);
     });
+
+    it('should have NaN', function () {
+      expect(Number).to.have.property('NaN');
+      expect(Number.propertyIsEnumerable('NaN')).to.equal(false);
+      expect(isNaN(Number.NaN)).to.equal(true);
+    });
+
+    it('should have MAX_VALUE', function () {
+      expect(Number).to.have.property('MAX_VALUE');
+      expect(Number.propertyIsEnumerable('MAX_VALUE')).to.equal(false);
+      expect(Number.MAX_VALUE).to.equal(1.7976931348623157e+308);
+    });
+
+    it('should have MIN_VALUE', function () {
+      expect(Number).to.have.property('MIN_VALUE');
+      expect(Number.propertyIsEnumerable('MIN_VALUE')).to.equal(false);
+      expect(Number.MIN_VALUE).to.equal(5e-324);
+    });
+
+    it('should have NEGATIVE_INFINITY', function () {
+      expect(Number).to.have.property('NEGATIVE_INFINITY');
+      expect(Number.propertyIsEnumerable('NEGATIVE_INFINITY')).to.equal(false);
+      expect(Number.NEGATIVE_INFINITY).to.equal(-Infinity);
+    });
+
+    it('should have POSITIVE_INFINITY', function () {
+      expect(Number).to.have.property('POSITIVE_INFINITY');
+      expect(Number.propertyIsEnumerable('POSITIVE_INFINITY')).to.equal(false);
+      expect(Number.POSITIVE_INFINITY).to.equal(Infinity);
+    });
   });
 
   describe('.parseInt()', function () {