-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse keywords that end code stream #885
Merged
pietermarsman
merged 10 commits into
pdfminer:master
from
qued:qued/parse-keywords-that-end-code-stream
Dec 31, 2023
Merged
fix: parse keywords that end code stream #885
pietermarsman
merged 10 commits into
pdfminer:master
from
qued:qued/parse-keywords-that-end-code-stream
Dec 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2023
I flipped the if-else for readability and simplified the test. Ready for merging now. Thanks for your time and contribution! |
This was referenced Aug 1, 2024
5 tasks
PhorstenkampFuzzy
added a commit
to PhorstenkampFuzzy/unstructured
that referenced
this pull request
Dec 17, 2024
Removed redundent patch as it is already merged in pdfminer/pdfminer.six#885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Closes 884. A small change so that if no keyword-terminating-pattern is found before the stream is exhausted, the keyword is considered terminated and sent for parsing.
How Has This Been Tested?
Included test that fails before change and succeeds after change. Also see attached document in linked issue for a PDF that is not parsed correctly before the change and is parsed correctly after.
Checklist