Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Rechunk in DataFrame.rows if needed #19628

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Nov 4, 2024

Fixes #19627.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Nov 4, 2024
@ritchie46 ritchie46 merged commit 0f64785 into pola-rs:main Nov 4, 2024
21 checks passed
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.92%. Comparing base (e52a598) to head (e78319c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ipe/src/executors/sinks/group_by/generic/source.rs 0.00% 1 Missing ⚠️
...olars-pipe/src/executors/sinks/output/file_sink.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19628   +/-   ##
=======================================
  Coverage   79.91%   79.92%           
=======================================
  Files        1536     1536           
  Lines      211659   211686   +27     
  Branches     2445     2445           
=======================================
+ Hits       169156   169186   +30     
+ Misses      41948    41945    -3     
  Partials      555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df.rows() is slower than list(df.iter_rows()) when the dataframe is chunked
2 participants