Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rounding for Decimal type #19760

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Nov 13, 2024

As part of #19630. This makes decimals already a bit more usable.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 13, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 63.20755% with 39 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (8cb7839) to head (1961a85).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-ops/src/series/ops/round.rs 63.20% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19760      +/-   ##
==========================================
- Coverage   79.55%   79.37%   -0.19%     
==========================================
  Files        1544     1550       +6     
  Lines      213240   214849    +1609     
  Branches     2441     2460      +19     
==========================================
+ Hits       169643   170531     +888     
- Misses      43048    43759     +711     
- Partials      549      559      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@coastalwhite coastalwhite marked this pull request as ready for review November 18, 2024 11:34
@ritchie46 ritchie46 merged commit 03ba07a into pola-rs:main Nov 19, 2024
25 checks passed
@coastalwhite coastalwhite deleted the feat/decimal-rounding branch November 19, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants