Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add proper tests for row encoding #19843

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

coastalwhite
Copy link
Collaborator

This adds the following method to be used internally to create tests.

  • pl.DataFrame._row_encode()
  • pl.Series._row_decode()

With this I added a bunch of tests to see the current state of row encoding.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.40%. Comparing base (420c0d9) to head (f195eb2).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/dataframe/frame.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19843      +/-   ##
==========================================
- Coverage   79.55%   79.40%   -0.16%     
==========================================
  Files        1544     1550       +6     
  Lines      213240   214840    +1600     
  Branches     2441     2460      +19     
==========================================
+ Hits       169645   170583     +938     
- Misses      43046    43698     +652     
- Partials      549      559      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite force-pushed the chore/row-encoding-tests branch from f8eb5a4 to f195eb2 Compare November 18, 2024 13:10
@ritchie46 ritchie46 merged commit 2420907 into pola-rs:main Nov 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants