Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Adjust flaky with_columns test #19844

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Nov 18, 2024

I think this fails in CI a bit more often than we'd want - to address this, I've increased num_columns from 2,000 to 10,000. I've also updated the assertion to check the runtime relative to the time taken for applying calling with_columns on 10 columns rather than an exact time.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Nov 18, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review November 18, 2024 10:04
@nameexhaustion nameexhaustion marked this pull request as draft November 18, 2024 10:23
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (402c15e) to head (26c6cf5).
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19844   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files        1550     1550           
  Lines      214743   214743           
  Branches     2460     2460           
=======================================
+ Hits       170457   170461    +4     
+ Misses      43727    43723    -4     
  Partials      559      559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nameexhaustion nameexhaustion marked this pull request as ready for review November 18, 2024 12:31
@ritchie46 ritchie46 merged commit 9527510 into pola-rs:main Nov 19, 2024
14 checks passed
@c-peters c-peters added the accepted Ready for implementation label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants