Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-enable hive partitioning if hive_schema was given #19902

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Nov 21, 2024

This is more of a quality-of-life change. After this PR if users do scan_parquet(<glob or file path>, hive_schema={...}), we will automatically enable hive partitioning instead of silently ignoring the hive_schema.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 21, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review November 21, 2024 08:49
@nameexhaustion nameexhaustion marked this pull request as draft November 21, 2024 08:49
@nameexhaustion nameexhaustion marked this pull request as ready for review November 21, 2024 09:10
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (3925085) to head (86b3c0e).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19902   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files        1554     1554           
  Lines      215611   215611           
  Branches     2452     2452           
=======================================
+ Hits       171278   171281    +3     
+ Misses      43775    43772    -3     
  Partials      558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ritchie46 ritchie46 merged commit eaf9b3f into pola-rs:main Nov 21, 2024
25 checks passed
@c-peters c-peters added the accepted Ready for implementation label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants