Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix panic with combination of hive and parquet prefiltering #19905

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Nov 21, 2024

Fixes #19766

We didn't handle hive columns properly in the prefiltering implementation

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.43%. Comparing base (eaf9b3f) to head (8cb8d72).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/parquet/read/read_impl.rs 83.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19905   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files        1554     1554           
  Lines      215610   215602    -8     
  Branches     2452     2452           
=======================================
- Hits       171276   171272    -4     
+ Misses      43776    43772    -4     
  Partials      558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

///
/// # Panics
/// Panics if either `df_columns` or `hive_columns` is empty.
pub(crate) fn merge_sorted_to_schema_order<D>(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factored out to a function for re-use

@nameexhaustion nameexhaustion marked this pull request as ready for review November 21, 2024 14:09
@ritchie46 ritchie46 merged commit 08191c2 into pola-rs:main Nov 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polars 1.13.0 filtering by date column doesn't work in lazyframe obtained via scan_parquet
2 participants