-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix panic with combination of hive and parquet prefiltering #19905
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19905 +/- ##
=======================================
Coverage 79.43% 79.43%
=======================================
Files 1554 1554
Lines 215610 215602 -8
Branches 2452 2452
=======================================
- Hits 171276 171272 -4
+ Misses 43776 43772 -4
Partials 558 558 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
/// | ||
/// # Panics | ||
/// Panics if either `df_columns` or `hive_columns` is empty. | ||
pub(crate) fn merge_sorted_to_schema_order<D>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factored out to a function for re-use
Fixes #19766
We didn't handle hive columns properly in the prefiltering implementation