perf: More efficient row encoding for pl.List
#19907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
9 tasks
coastalwhite
force-pushed
the
perf/row-encoding-lists
branch
from
d32c989 to
b408536
Compare
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
coastalwhite
force-pushed
the
perf/row-encoding-lists
branch
from
c3bc614 to
8fdb32e
Compare
This changes the row-encoding of the `pl.List` to be marked with `continuation` and `termination` bytes instead of as a variable encoding. This removes the need for an intermediate buffer, allows empty encodings (e.g. `pl.Null`) and generally makes the encoding more compact and efficient. [skip ci]
ritchie46
force-pushed
the
perf/row-encoding-lists
branch
from
8fdb32e to
5b7ff01
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19907 +/- ##
==========================================
- Coverage 79.49% 79.45% -0.05%
==========================================
Files 1555 1555
Lines 216213 216140 -73
Branches 2456 2456
==========================================
- Hits 171872 171725 -147
- Misses 43783 43857 +74
Partials 558 558 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the row-encoding of the
pl.Listto be marked withcontinuationandterminationbytes instead of as a variable encoding. This removes the need for an intermediate buffer, allows empty encodings (e.g.pl.Null) and generally makes the encoding more compact and efficient.Continuation of #19874.