Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise InvalidOperationError for invalid float to decimal casts (e.g. Inf, NaN) #19938

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

lukemanley
Copy link
Contributor

closes #19934

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (54a112d) to head (7a03034).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19938   +/-   ##
=======================================
  Coverage   79.48%   79.48%           
=======================================
  Files        1555     1555           
  Lines      216213   216213           
  Branches     2456     2456           
=======================================
+ Hits       171862   171863    +1     
+ Misses      43793    43792    -1     
  Partials      558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ritchie46 ritchie46 merged commit adf703b into pola-rs:main Nov 23, 2024
26 checks passed
@lukemanley lukemanley deleted the invalid-cast-float-to-decimal branch December 6, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casting x/0 (Inf) to Decimal causes panic (instead of error)
2 participants