Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump Rust toolchain to nightly-2024-11-28 #20064

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Nov 29, 2024

Two new lints that affect us:

And an update to the config flag checks in external macros: rust-lang/rust#132577

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars labels Nov 29, 2024
@stinodego stinodego marked this pull request as ready for review November 29, 2024 10:44
@stinodego stinodego force-pushed the bump-toolchain-2024-11-29 branch from 30528e6 to 8b279ca Compare November 29, 2024 11:00
@stinodego stinodego marked this pull request as draft November 29, 2024 12:31
@stinodego stinodego force-pushed the bump-toolchain-2024-11-29 branch from 8b279ca to fe03770 Compare November 29, 2024 12:33
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (44ddbc2) to head (fe03770).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/array/utf8/mutable.rs 0.00% 1 Missing ⚠️
crates/polars-io/src/file_cache/cache_lock.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20064      +/-   ##
==========================================
+ Coverage   79.52%   79.53%   +0.01%     
==========================================
  Files        1563     1563              
  Lines      217194   217144      -50     
  Branches     2464     2464              
==========================================
- Hits       172729   172712      -17     
+ Misses      43905    43872      -33     
  Partials      560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego changed the title build: Bump Rust toolchain to nightly-2024-11-29 build: Bump Rust toolchain to nightly-2024-11-28 Nov 29, 2024
@stinodego stinodego marked this pull request as ready for review November 29, 2024 13:17
@ritchie46 ritchie46 merged commit 88d102a into main Nov 29, 2024
21 checks passed
@ritchie46 ritchie46 deleted the bump-toolchain-2024-11-29 branch November 29, 2024 18:48
@c-peters c-peters added the accepted Ready for implementation label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants