Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade sqlparser-rs from version 0.49 to 0.52 #20110

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Dec 2, 2024

@stinodego: as requested, the sqlparser-rs update, coming to you from Muscat airport in Oman... 🙂🌴✈️

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (58f763a) to head (226d6b7).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-sql/src/sql_expr.rs 88.23% 2 Missing ⚠️
crates/polars-sql/src/context.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20110      +/-   ##
==========================================
- Coverage   79.53%   79.53%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      217115   217131      +16     
  Branches     2464     2464              
==========================================
+ Hits       172679   172686       +7     
- Misses      43876    43885       +9     
  Partials      560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👌

@stinodego stinodego merged commit 4c1c51c into pola-rs:main Dec 2, 2024
20 checks passed
@alexander-beedie alexander-beedie deleted the sqlparser-upgrade branch December 2, 2024 16:30
nimit pushed a commit to nimit/polars that referenced this pull request Dec 2, 2024
@alexander-beedie alexander-beedie changed the title build: Upgrade sqlparser-rs from version 0.49 to 0.52 build: Upgrade sqlparser-rs from version 0.49 to 0.52 Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants