Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Fix typo in assertion in datatype copy test #20121

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

henryharbeck
Copy link
Contributor

Spotted while poking around.
Did a quick check on main for any other instances of assert {self} == {self} and there were none.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (0263868) to head (3907b66).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20121   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files        1563     1563           
  Lines      217184   217185    +1     
  Branches     2465     2465           
=======================================
+ Hits       172706   172707    +1     
  Misses      43917    43917           
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - well spotted!

@stinodego stinodego merged commit 875016c into pola-rs:main Dec 3, 2024
13 checks passed
@henryharbeck henryharbeck deleted the typo branch December 4, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants