feat: Experimental cloud write support #20129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20129 +/- ##
==========================================
+ Coverage 79.52% 79.57% +0.05%
==========================================
Files 1563 1563
Lines 217184 217395 +211
Branches 2465 2472 +7
==========================================
+ Hits 172706 172989 +283
+ Misses 43917 43838 -79
- Partials 561 568 +7 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
commented
Dec 4, 2024
| @@ -216,6 +231,98 @@ pub enum PythonScanSourceInput { | |||
| File(File), | |||
| } | |||
|
|
|||
| fn try_get_pyfile( | |||
There was a problem hiding this comment.
this code is just moved into a function from 2 places
ritchie46
approved these changes
Dec 4, 2024
nameexhaustion
changed the title
nameexhaustion
added
the
breaking rust
nameexhaustion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for directly writing to cloud paths for Parquet, CSV and IPC.
Fixes #14630
Fixes #19749