Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Utilize the RangedUniqueKernel for Enum/Categorical #20150

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Dec 4, 2024

I was improving the kernel in preparation for some Parquet work and I wanted to apply it somewhere before I got to the actual Parquet work.

This does lead to significant speedups (~11x in the following benchmark).

image

I was improving the kernel in preparation for some Parquet work and I wanted to
apply it somewhere before I got to the actual Parquet work.

This does lead to significant speedups.
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 45.04505% with 122 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (bcfa7ec) to head (bf143cd).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-compute/src/unique/primitive.rs 41.73% 74 Missing ⚠️
crates/polars-compute/src/unique/dictionary.rs 31.57% 26 Missing ⚠️
...rc/chunked_array/logical/categorical/ops/unique.rs 33.33% 12 Missing ⚠️
crates/polars-compute/src/unique/boolean.rs 78.12% 7 Missing ⚠️
crates/polars-arrow/src/array/dictionary/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20150      +/-   ##
==========================================
- Coverage   79.57%   79.57%   -0.01%     
==========================================
  Files        1563     1564       +1     
  Lines      217395   217474      +79     
  Branches     2472     2472              
==========================================
+ Hits       172986   173048      +62     
- Misses      43841    43858      +17     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit cbc0ea0 into pola-rs:main Dec 5, 2024
22 checks passed
@coastalwhite coastalwhite deleted the perf/enum-cat-unique branch December 5, 2024 08:10
@c-peters c-peters added the accepted Ready for implementation label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants