Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Issue warning when using to_struct() without a list of field names #20158

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 5, 2024

ref

We need to wait until 2.0 to fix the API for this, for now we can add a warning

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Dec 5, 2024
@ritchie46
Copy link
Member

Do we have a milestone 2.0 issue for this?

@nameexhaustion
Copy link
Collaborator Author

Do we have a milestone 2.0 issue for this?

I made a draft here, it hasn't been reviewed yet though

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.58%. Comparing base (3fb10e8) to head (da68a12).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/expr/list.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20158   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files        1563     1564    +1     
  Lines      217417   217480   +63     
  Branches     2472     2473    +1     
=======================================
+ Hits       173023   173078   +55     
- Misses      43826    43833    +7     
- Partials      568      569    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 5, 2024 09:26
@ritchie46 ritchie46 merged commit 588a22b into pola-rs:main Dec 5, 2024
13 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants