Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Clean up some remnants of Python 3.8 support #20293

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Dec 13, 2024

There was still a bunch of logic specific to Python 3.8 in the code base.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Dec 13, 2024
@stinodego stinodego marked this pull request as ready for review December 13, 2024 21:48
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (84d317a) to head (b9de395).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/_utils/convert.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20293   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files        1565     1565           
  Lines      218328   218319    -9     
  Branches     2478     2477    -1     
=======================================
- Hits       173820   173817    -3     
+ Misses      43941    43936    -5     
+ Partials      567      566    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Removing dead code counts for double points... :)

@ritchie46 ritchie46 merged commit b799459 into main Dec 14, 2024
18 checks passed
@ritchie46 ritchie46 deleted the cleanup-3.8 branch December 14, 2024 07:20
@c-peters c-peters added the accepted Ready for implementation label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants