fix: Flip order on right join #20358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnherfst
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
ritchie46
reviewed
Dec 19, 2024
| @@ -81,6 +81,18 @@ pub enum MaintainOrderJoin { | |||
| RightLeft, | |||
| } | |||
|
|
|||
| impl MaintainOrderJoin { | |||
| pub fn flip(&self) -> Self { | |||
There was a problem hiding this comment.
Can we set this to minimal need publicity.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20358 +/- ##
==========================================
- Coverage 79.13% 79.11% -0.03%
==========================================
Files 1572 1572
Lines 219839 219929 +90
Branches 2462 2465 +3
==========================================
+ Hits 173970 173992 +22
- Misses 45301 45369 +68
Partials 568 568 ☔ View full report in Codecov by Sentry. |
| @@ -1243,6 +1243,20 @@ def test_join_preserve_order_left() -> None: | |||
| 5, | |||
| ] | |||
|
|
|||
| right_left = left.join(right, on="a", how="right", maintain_order="left").collect() | |||
There was a problem hiding this comment.
It feels a bit odd to have tests for right joins in the test_join_preserve_order_left function, but oh well.
IMO the fact that the right join is implemented in terms of the left join is just a (clever) implementation detail.
Leaning on that was what led to this bug in the first place 😁
alexander-beedie
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20350
When doing a right join the dataframes were swapped and a left join was done. For this the maintain_order argument also needs to be flipped. Thanks @rodrigogiraoserrao for catching this.