feat: Add Azure credential provider using DefaultAzureCredential()
#20384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
nameexhaustion
commented
Dec 20, 2024
| # } | ||
| # ] | ||
|
|
||
| return json.loads(subprocess.check_output(cmd))[0]["value"] |
There was a problem hiding this comment.
This is ported from some recently added logic to the rust side from (#20357), we need this here as the Python credential provider will override the one set by the Rust side if it is passed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20384 +/- ##
==========================================
+ Coverage 78.38% 79.13% +0.74%
==========================================
Files 1572 1566 -6
Lines 219962 219277 -685
Branches 2465 2470 +5
==========================================
+ Hits 172423 173525 +1102
+ Misses 46971 45184 -1787
Partials 568 568 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
reviewed
Dec 20, 2024
|
|
||
| cmd = az_cmd if sys.platform != "win32" else ["cmd", "/C", *az_cmd] | ||
|
|
||
| # [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have anything working locally with
DefaultAzureCredential(), but it apparently works for some authentication setups -